netdev - Re: [PATCH 3/3] rocker: set feature NETIF_F_HW_SWITCH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 5 Dec 2014 12:44:47 +0800
From:	Jianhua Xie <jianhua.xie@...escale.com>
To:	Roopa Prabhu <roopa@...ulusnetworks.com>
CC:	<jiri@...nulli.us>, <sfeldma@...il.com>, <jhs@...atatu.com>,
	<bcrl@...ck.org>, <tgraf@...g.ch>, <john.fastabend@...il.com>,
	<stephen@...workplumber.org>, <linville@...driver.com>,
	<nhorman@...driver.com>, <nicolas.dichtel@...nd.com>,
	<vyasevic@...hat.com>, <f.fainelli@...il.com>,
	<buytenh@...tstofly.org>, <aviadr@...lanox.com>,
	<netdev@...r.kernel.org>, <davem@...emloft.net>,
	<shm@...ulusnetworks.com>, <gospo@...ulusnetworks.com>,
	jianhua Xie <jianhua.xie@...escale.com>
Subject: Re: [PATCH 3/3] rocker: set feature NETIF_F_HW_SWITCH_OFFLOAD


在 2014年12月05日 12:14, Roopa Prabhu 写道:
> On 12/4/14, 7:25 PM, Jianhua Xie wrote:
>>
>> 在 2014年12月05日 10:26, roopa@...ulusnetworks.com 写道:
>>> From: Roopa Prabhu <roopa@...ulusnetworks.com>
>>>
>>> This patch just sets the feature flag on rocker ports
>>> ---
>>>   drivers/net/ethernet/rocker/rocker.c |    3 ++-
>>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/net/ethernet/rocker/rocker.c 
>>> b/drivers/net/ethernet/rocker/rocker.c
>>> index fded127..3fe19b0 100644
>>> --- a/drivers/net/ethernet/rocker/rocker.c
>>> +++ b/drivers/net/ethernet/rocker/rocker.c
>>> @@ -4003,7 +4003,8 @@ static int rocker_probe_port(struct rocker 
>>> *rocker, unsigned int port_number)
>>>                  NAPI_POLL_WEIGHT);
>>>       rocker_carrier_init(rocker_port);
>>>   -    dev->features |= NETIF_F_HW_VLAN_CTAG_FILTER;
>>> +    dev->features |= NETIF_F_HW_VLAN_CTAG_FILTER |
>>> +                     NETIF_F_HW_SWITCH_OFFLOAD;
>> Do you have a plan on enabling/disabling  this flag dynamically by 
>> ethtool?
>
> I have not thought about it yet. But if this gets accepted, then yes, 
> I will have an ethtool way for drivers who want it.
> if we have a IFF_ flag for this (which is also one of my alternate 
> proposals), there will be a netlink way to set it on and off.
>
Got it with thanks.
Best Regards.
Jianhua

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html