lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 5 Dec 2014 13:17:30 +0100 From: Jiri Pirko <jiri@...nulli.us> To: Jamal Hadi Salim <jhs@...atatu.com> Cc: roopa@...ulusnetworks.com, sfeldma@...il.com, bcrl@...ck.org, tgraf@...g.ch, john.fastabend@...il.com, stephen@...workplumber.org, linville@...driver.com, nhorman@...driver.com, nicolas.dichtel@...nd.com, vyasevic@...hat.com, f.fainelli@...il.com, buytenh@...tstofly.org, aviadr@...lanox.com, netdev@...r.kernel.org, davem@...emloft.net, shm@...ulusnetworks.com, gospo@...ulusnetworks.com Subject: Re: [PATCH 1/3] netdev: introduce new NETIF_F_HW_SWITCH_OFFLOAD feature flag for switch device offloads Fri, Dec 05, 2014 at 01:06:50PM CET, jhs@...atatu.com wrote: >On 12/04/14 21:26, roopa@...ulusnetworks.com wrote: >>From: Roopa Prabhu <roopa@...ulusnetworks.com> >> >>This is a generic high level feature flag for all switch asic features today. >> >>switch drivers set this flag on switch ports. Logical devices like >>bridge, bonds, vxlans can inherit this flag from their slaves/ports. >> >>I had to use SWITCH in the name to avoid ambiguity with other feature >>flags. But, since i have been harping about not calling it 'switch', >>I am welcome to any suggestions :) >> > >I know in this use case it is a switch. But please dont use that term >for things that we are going to use as generic offload descriptors. >How about just simple: NETIF_F_HW_DEV_OFFLOAD_BIT What that should tell it stands for? I think we need something more specific. >BTW: Didnt you already have a netdev specific offload feature flag? > >cheers, >jamal > >>An alternative to using a feature flag is to use a IFF_HW_OFFLOAD >>in net_device_flags. >>--- >> include/linux/netdev_features.h | 2 ++ >> 1 file changed, 2 insertions(+) >> >>diff --git a/include/linux/netdev_features.h b/include/linux/netdev_features.h >>index 8e30685..68db1de 100644 >>--- a/include/linux/netdev_features.h >>+++ b/include/linux/netdev_features.h >>@@ -66,6 +66,7 @@ enum { >> NETIF_F_HW_VLAN_STAG_FILTER_BIT,/* Receive filtering on VLAN STAGs */ >> NETIF_F_HW_L2FW_DOFFLOAD_BIT, /* Allow L2 Forwarding in Hardware */ >> NETIF_F_BUSY_POLL_BIT, /* Busy poll */ >>+ NETIF_F_HW_SWITCH_OFFLOAD_BIT, /* HW switch offload */ >> >> /* >> * Add your fresh new feature above and remember to update >>@@ -124,6 +125,7 @@ enum { >> #define NETIF_F_HW_VLAN_STAG_TX __NETIF_F(HW_VLAN_STAG_TX) >> #define NETIF_F_HW_L2FW_DOFFLOAD __NETIF_F(HW_L2FW_DOFFLOAD) >> #define NETIF_F_BUSY_POLL __NETIF_F(BUSY_POLL) >>+#define NETIF_F_HW_SWITCH_OFFLOAD __NETIF_F(HW_SWITCH_OFFLOAD) >> >> /* Features valid for ethtool to change */ >> /* = all defined minus driver/device-class-related */ >> > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists