netdev - Re: [PATCH net] tcp: fix more NULL deref after prequeue changes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 09 Dec 2014 21:39:49 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	dann.frazier@...onical.com, netdev@...r.kernel.org
Subject: Re: [PATCH net] tcp: fix more NULL deref after prequeue changes

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Tue, 09 Dec 2014 09:56:08 -0800

> From: Eric Dumazet <edumazet@...gle.com>
> 
> When I cooked commit c3658e8d0f1 ("tcp: fix possible NULL dereference in
> tcp_vX_send_reset()") I missed other spots we could deref a NULL
> skb_dst(skb)
> 
> Again, if a socket is provided, we do not need skb_dst() to get a
> pointer to network namespace : sock_net(sk) is good enough.
> 
> Reported-by: Dann Frazier <dann.frazier@...onical.com>
> Bisected-by: Dann Frazier <dann.frazier@...onical.com>
> Tested-by: Dann Frazier <dann.frazier@...onical.com>
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Fixes: ca777eff51f7 ("tcp: remove dst refcount false sharing for prequeue mode")

Applied and queued up for 3.18-stable.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html