netdev - Re: PATCH] Revert "bridge: include in6.h in if_bridge.h for struct in6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 09 Dec 2014 23:49:54 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	stephen@...workplumber.org
Cc:	gregory.0xf0@...il.com, f.fainelli@...il.com,
	xiyou.wangcong@...il.com, netdev@...r.kernel.org
Subject: Re: PATCH] Revert "bridge: include in6.h in if_bridge.h for struct
 in6_addr"

From: Stephen Hemminger <stephen@...workplumber.org>
Date: Tue, 9 Dec 2014 20:30:07 -0800

> This reverts commit 66f1c44887ba4f47d617f8ae21cf8e04e1892bd7.
> 
> iproute2 uses sanitized kernel headers, and this change broke the build.
> The problem is that the iproute2 ip/iplink_bridge_slave.c include if_bridge.h
> but this causes a redefintion error when Glibc <netlink/in.h> is included.
> 
> Since iproute2 is arguably the most important user of network headers,
> the uapi header change should be reverted.
> 
> Signed-off-by: Stephen Hemminger <stephen@...workplumber.org>

Stephen, please understand first the reason for this change.

GLIBC and the kernel fight over various definitions of core
networking types.

The only way to resolve this in the long term is this change
in question.

If you can make iproute2 work with both the new and the old
mechanims, please do so instead of reverting this important
change.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html