[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Fri, 12 Dec 2014 22:58:16 +0900
From: Simon Horman <horms@...ge.net.au>
To: Tobias Klauser <tklauser@...tanz.ch>
Cc: netdev@...r.kernel.org
Subject: Re: [PATCH net] net: ethernet: davicom: Allow to select DM9000 for
nios2
On Fri, Dec 12, 2014 at 01:40:15PM +0100, Tobias Klauser wrote:
> On 2014-12-12 at 12:28:42 +0100, Simon Horman <horms@...ge.net.au> wrote:
> > On Fri, Dec 12, 2014 at 10:21:11AM +0100, Tobias Klauser wrote:
> > > This chip is present on older revisions of the DE2 development kit.
> > >
> > > Signed-off-by: Tobias Klauser <tklauser@...tanz.ch>
> >
> > I wonder if || COMPILE_TEST should also be added to allow extra build
> > coverage. Is there a specific reason it won't compile more widely?
> >
> > Likewise for your smsc patch.
>
> Good point. I don't think there's a reason for it not being compiled
> more widely. Should I update my patches accordingly or send a separate
> patch?
I'm not the maintainer but a follow-up patch or patches seems reasonable to me.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists