[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Fri, 12 Dec 2014 17:45:29 +0100
From: Tobias Klauser <tklauser@...tanz.ch>
To: David Miller <davem@...emloft.net>
Cc: tony@...mide.com, nico@...xnic.net, netdev@...r.kernel.org
Subject: Re: [PATCH net v2] net: smc91x: Fix build without gpiolib
On 2014-12-12 at 17:30:20 +0100, David Miller <davem@...emloft.net> wrote:
> From: Tobias Klauser <tklauser@...tanz.ch>
> Date: Fri, 12 Dec 2014 17:27:46 +0100
>
> > GPIO is not needed in all configurations of the chip, they are optional.
> > That's why I was going for the ugly #ifdef solution.
> >
> > It seems that there are stubs for the functions in question in
> > linux/gpio/consumer.h already as Tony suggested. Thus, adding an
> > #include <linux/gpio/consumer.h> to the driver should be enough. I'll
> > send an updated patch.
>
> So for the "configurations" that need it, how does the user figure out
> that GPIO is needed?
Probably ionly by consulting the manual of the board usingthe chip.
Which presumably very few users will do.
> In my opinion, if the code blocks enabling the configurations that
> need this are enabled, so should GPIO be depended upon.
>
> I think, at a minimum, when CONFIG_OF is enabled smsc91x should
> require GPIO.
Agreed. This is the better solution, causing less surprises for the
user. Should this be a "select GPIOLIB if OF" then?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists