netdev - Re: [iproute2] tc: Show classes more hierarchically]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 18 Dec 2014 10:46:06 -0200
From:	Marcelo Ricardo Leitner <marcelo.leitner@...il.com>
To:	Vadim Kochan <vadim4j@...il.com>
CC:	Stephen Hemminger <stephen@...workplumber.org>,
	netdev@...r.kernel.org
Subject: Re: [iproute2] tc: Show classes more hierarchically]

On 18-12-2014 10:23, Vadim Kochan wrote:
> On Thu, Dec 18, 2014 at 10:26:37AM -0200, Marcelo Ricardo Leitner wrote:
>>> +---1:1(htb) rate 6Mbit ceil 6Mbit burst 15Kb cburst 1599b
>>>      |    * Send 100 pkts ...
>>>      |    * Rate 10mbit ...
>>>      +---1:10(htb) rate 5Mbit ceil 5Mbit burst 15Kb cburst 1600b
>>>      |   |    * Send 100 pkts ...
>>>      |   |    * Rate 10mbit ...
>>>      |   +---1:11(htb) rate 3Mbit ceil 6Mbit burst 15Kb cburst 1599b
>>>      |   |   |    * Send 100 pkts ...
>>>      |   |   |    * Rate 10mbit ...
>>>      |   |   +---1:111(htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b
>>>      |   |   |   |    * Send 100 pkts ...
>>>      |   |   |   |    * Rate 10mbit ...
>>                     ^ these are confusing IMHO, rest looks good to me
>>
>>    Marcelo
>>
>
>
> Yes, just fixed it to :

Cool

> +---1:2(htb) rate 6Mbit ceil 6Mbit burst 15Kb cburst 1599b
> |   |    * Send 100 pkts ...
> |   |    * Rate 10mbit ...
> |   +---1:40(htb) prio 0 rate 5Mbit ceil 5Mbit burst 15Kb cburst 1600b
> |   |        * Send 100 pkts ...
> |   |        * Rate 10mbit ...
> |   +---1:50(htb) prio 0 rate 3Mbit ceil 6Mbit burst 15Kb cburst 1599b
> |   |        * Send 100 pkts ...
> |   |        * Rate 10mbit ...
> |   +---1:60(htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b
> |            * Send 100 pkts ...
> |            * Rate 10mbit ...
> |
> +---1:1(htb) rate 6Mbit ceil 6Mbit burst 15Kb cburst 1599b
>      |    * Send 100 pkts ...
>      |    * Rate 10mbit ...
>      +---1:10(htb) rate 5Mbit ceil 5Mbit burst 15Kb cburst 1600b
>      |   |    * Send 100 pkts ...
>      |   |    * Rate 10mbit ...
>      |   +---1:11(htb) rate 3Mbit ceil 6Mbit burst 15Kb cburst 1599b
>      |   |   |    * Send 100 pkts ...
>      |   |   |    * Rate 10mbit ...
>      |   |   +---1:111(htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b
>      |   |   |        * Send 100 pkts ...
>      |   |   |        * Rate 10mbit ...
>      |   |   +---1:112(htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b
>      |   |            * Send 100 pkts ...
>      |   |            * Rate 10mbit ...
>      |   |
>      |   +---1:12(htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b
>      |            * Send 100 pkts ...
>      |            * Rate 10mbit ...
>      |
>      +---1:20(htb) prio 0 rate 3Mbit ceil 6Mbit burst 15Kb cburst 1599b
>      |        * Send 100 pkts ...
>      |        * Rate 10mbit ...
>      +---1:30(htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b
>               * Send 100 pkts ...
>               * Rate 10mbit ...
>
> I am not sure about the better format to print stats - use '*' or '>' as
> prefix, '*' - seems better ?

TBH I don't think we need one in there. It's already linked to the items 
due to the tree on them. If you just align them to start right where the 
the first word after the ')' begins, it would be good. Like:

       |   +---1:11(htb) rate 3Mbit ceil 6Mbit burst 15Kb cburst 1599b
       |   |   |         Send 100 pkts ...
       |   |   |         Rate 10mbit ...
       |   |   +---1:111(htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb 
cburst 1599b
       |   |   |              Send 100 pkts ...
       |   |   |              Rate 10mbit ...
       |   |   +---1:112(htb) prio 0 rate 1Kbit ceil 6Mbit burst 15Kb 
cburst 1599b

But I don't know how large this will get..

Yet I don't mind having one marker in there. Let's see what others think 
about it.

Regards,
Marcelo

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html