lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 20 Dec 2014 16:48:08 +0300 From: Sergei Shtylyov <sergei.shtylyov@...entembedded.com> To: Jia-Ju Bai <baijiaju1990@....com>, netdev@...r.kernel.org, jgarzik@...ox.com, shangh@...ltek.com.tw Subject: Re: [PATCH] 8139too in linux-3.18.0: some potential bugs On 12/20/2014 4:20 PM, Jia-Ju Bai wrote: > I have actually tested 8139too driver on the real hardware(Realtek RTL8139D > PCI Ethernet Controller), and find some potential bugs: > The target file is drivers/net/ethernet/realtek/8139too.c, which is used to > build 8139too.ko. > (1) In the normal process of 8139too, netif_napi_add is called in > rtl8139_init_one, but netif_napi_del is not called in rtl8139_remove_one. > However, many other ethernet card drivers call them in pairs, even in the > error handling paths, such as r8169 and igb. > (2) In the normal process of 8139too, pci_enable_device and > pci_disable_device are called in pairs in rtl8139_init_board(in > rtl8139_init_one) and rtl8139_remove_one. However, when pci_enable_device > has been called and pci_request_regions is failed in rtl8139_init_board, > "err_out" segment in rtl8139_init_board is executed immediately to exit, but > pci_disable_device is not called because "disable_dev_on_err = 0". Again, please fix one issue per patch. > Meanwhile, I also write the patch to fix the bugs. I have run the patch on > the hardware, it can work normally and fix the above bugs. Too bad you didn't provide a sign-off... WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists