lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 2 Jan 2015 16:16:34 -0500 From: Kostya Belezko <bkostya@...mail.com> To: David Miller <davem@...emloft.net> CC: "nios2-dev@...ts.rocketboards.org" <nios2-dev@...ts.rocketboards.org>, "netdev@...r.kernel.org" <netdev@...r.kernel.org> Subject: RE: [PATCH v2][Nios2-dev] Altera TSE: Add missing phydev ---------------------------------------- > Date: Fri, 2 Jan 2015 16:07:03 -0500 > To: bkostya@...mail.com > CC: nios2-dev@...ts.rocketboards.org; netdev@...r.kernel.org > Subject: Re: [PATCH v2][Nios2-dev] Altera TSE: Add missing phydev > From: davem@...emloft.net > > From: Kostya Belezko <bkostya@...mail.com> > Date: Fri, 2 Jan 2015 15:57:29 -0500 > >> What do you mean by phy_disconnect() is down? >> Originally priv->phydev is NULL (and remains null forever) right after 'ifdown eth0' > > I'm saying that the code should probably keep phydev non-NULL and just > take the PHY down/up during these events. Yes, this is what the patch intends to achieve. It keeps phydev non-NULL and calls phy_stop, shy_start respectively. phy_disconnect is called upon rmmod. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists