netdev - Re: [PATCH] GMAC: fix simple

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 02 Jan 2015 16:46:45 -0800
From:	Joe Perches <joe@...ches.com>
To:	kbuild test robot <fengguang.wu@...el.com>
Cc:	Roger Chen <roger.chen@...k-chips.com>, kbuild-all@...org,
	Giuseppe Cavallaro <peppe.cavallaro@...com>,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] GMAC: fix simple_return.cocci warnings

On Sat, 2015-01-03 at 08:25 +0800, kbuild test robot wrote:
> drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c:425:1-4: WARNING: end returns can be simpified
> 
>  Simplify a trivial if-return sequence.  Possibly combine with a
>  preceding function call.
> Generated by: scripts/coccinelle/misc/simple_return.cocci
> 
> CC: Roger Chen <roger.chen@...k-chips.com>
> Signed-off-by: Fengguang Wu <fengguang.wu@...el.com>
> ---
> 
>  dwmac-rk.c |    6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c
> @@ -422,11 +422,7 @@ static int rk_gmac_init(struct platform_
>  	if (ret)
>  		return ret;
>  
> -	ret = gmac_clk_enable(bsp_priv, true);
> -	if (ret)
> -		return ret;
> -
> -	return 0;
> +	return gmac_clk_enable(bsp_priv, true);

I think this change is not particularly better.

When the pattern is multiply repeated like:

{
	...
	foo = bar();
	if (foo)
		return foo;

	foo = baz();
	if (foo)
		return foo;

	foo = qux();
	if (foo)
		return foo;

	return 0;
}

I think it's better to not change the last
test in the sequence just to minimize overall
line count.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html