lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 11 Jan 2015 22:38:13 +0100 From: Daniel Borkmann <dborkman@...hat.com> To: Christoph Jaeger <cj@...ux.com> CC: davem@...emloft.net, willemb@...gle.com, edumazet@...gle.com, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH net] packet: bail out of packet_snd() if L2 header creation fails On 01/11/2015 07:01 PM, Christoph Jaeger wrote: > Due to a misplaced parenthesis, the expression > > (unlikely(offset) < 0), > > which expands to > > (__builtin_expect(!!(offset), 0) < 0), > > never evaluates to true. Therefore, when sending packets with > PF_PACKET/SOCK_DGRAM, packet_snd() does not abort as intended > if the creation of the layer 2 header fails. > > Spotted by Coverity - CID 1259975 ("Operands don't affect result"). > > Fixes: 9c7077622dd9 ("packet: make packet_snd fail on len smaller than l2 header") > Signed-off-by: Christoph Jaeger <cj@...ux.com> Thanks, Christoph! Acked-by: Daniel Borkmann <dborkman@...hat.com> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists