netdev - Re: [PATCH net-next v2 2/3] netlink: eliminate nl_sk_hash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 13 Jan 2015 00:08:51 +0000
From:	Thomas Graf <tgraf@...g.ch>
To:	Ying Xue <ying.xue@...driver.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v2 2/3] netlink: eliminate nl_sk_hash_lock

On 01/12/15 at 02:52pm, Ying Xue wrote:
> As rhashtable_lookup_compare_insert() can guarantee the process
> of search and insertion is atomic, it's safe to eliminate the
> nl_sk_hash_lock. After this, object insertion or removal will
> be protected with per bucket lock on write side while object
> lookup is guarded with rcu read lock on read side.
> 
> Signed-off-by: Ying Xue <ying.xue@...driver.com>
> Cc: Thomas Graf <tgraf@...g.ch>

LGTM now, nice!

Acked-by: Thomas Graf <tgraf@...g.ch>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html