lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 13 Jan 2015 15:36:35 +0100 From: Jiri Pirko <jiri@...nulli.us> To: Arnd Bergmann <arnd@...db.de> Cc: netdev@...r.kernel.org, David Miller <davem@...emloft.net>, Scott Feldman <sfeldma@...il.com>, linux-arm-kernel@...ts.infradead.org Subject: Re: [PATCH] rocker: fix harmless warning on 32-bit machines Tue, Jan 13, 2015 at 03:23:52PM CET, arnd@...db.de wrote: >The rocker driver tries to assign a pointer to a 64-bit integer >and then back to a pointer. This is safe on all architectures, >but causes a compiler warning when pointers are shorter than >64-bit: > >rocker/rocker.c: In function 'rocker_desc_cookie_ptr_get': >rocker/rocker.c:809:9: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] > return (void *) desc_info->desc->cookie; > ^ > >This adds another cast to uintptr_t to tell the compiler >that it's safe. > >Signed-off-by: Arnd Bergmann <arnd@...db.de> Acked-by: Jiri Pirko <jiri@...nulli.us> > >diff --git a/drivers/net/ethernet/rocker/rocker.c b/drivers/net/ethernet/rocker/rocker.c >index 2f398fa4b9e6..cad8cf962cdf 100644 >--- a/drivers/net/ethernet/rocker/rocker.c >+++ b/drivers/net/ethernet/rocker/rocker.c >@@ -806,13 +806,13 @@ static bool rocker_desc_gen(struct rocker_desc_info *desc_info) > > static void *rocker_desc_cookie_ptr_get(struct rocker_desc_info *desc_info) > { >- return (void *) desc_info->desc->cookie; >+ return (void *)(uintptr_t)desc_info->desc->cookie; > } > > static void rocker_desc_cookie_ptr_set(struct rocker_desc_info *desc_info, > void *ptr) > { >- desc_info->desc->cookie = (long) ptr; >+ desc_info->desc->cookie = (uintptr_t) ptr; > } > > static struct rocker_desc_info * > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists