netdev - Re: [PATCH net-next] rhashtable: rhashtable_remove() must unlink in both tbl and future

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 20 Jan 2015 21:44:09 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Thomas Graf <tgraf@...g.ch>, davem@...emloft.net,
	Ying Xue <ying.xue@...driver.com>
CC:	"richard.alpe@...csson.com >> Richard Alpe" 
	<richard.alpe@...csson.com>, Netdev <netdev@...r.kernel.org>,
	tipc-discussion@...ts.sourceforge.net
Subject: Re: [PATCH net-next] rhashtable: rhashtable_remove() must unlink
 in both tbl and future_tbl

Hello.

On 01/20/2015 07:58 PM, Thomas Graf wrote:

> As removals can occur during resizes, entries may be referred to from
> both tbl and future_tbl when the removal is requested. Therefore
> rhashtable_remove() must unlink the entry in both tables if this is
> the case. The existing code did search both tables but stopped when it
> hit the first match.

> Failing to do so resulted in use after remove.

    Er, failing to do what? Stopping when it hit the first match?

> Fixes: 97defe1 ("rhashtable: Per bucket locks & deferred expansion/shrinking")

    SHA1 should be 12 hex digits in this case, accordong to 
Documentation/SubmittingPatches.

> Reported-by: Ying Xue <ying.xue@...driver.com>
> Signed-off-by: Thomas Graf <tgraf@...g.ch>

[...]

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html