lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 25 Jan 2015 13:59:19 +0200 From: "Ahmed S. Darwish" <darwish.07@...il.com> To: Sergei Shtylyov <sergei.shtylyov@...entembedded.com> Cc: Olivier Sobrie <olivier@...rie.be>, Oliver Hartkopp <socketcan@...tkopp.net>, Wolfgang Grandegger <wg@...ndegger.com>, Marc Kleine-Budde <mkl@...gutronix.de>, Andri Yngvason <andri.yngvason@...el.com>, Linux-CAN <linux-can@...r.kernel.org>, netdev <netdev@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org> Subject: Re: [PATCH v5 4/5] can: kvaser_usb: Retry the first bulk transfer on -ETIMEDOUT On Wed, Jan 21, 2015 at 03:24:46PM +0300, Sergei Shtylyov wrote: > Hello. > > On 1/21/2015 12:48 AM, Ahmed S. Darwish wrote: > > >From: Ahmed S. Darwish <ahmed.darwish@...eo.com> > > >On some x86 laptops, plugging a Kvaser device again after an > >unplug makes the firmware always ignore the very first command. > >For such a case, provide some room for retries instead of > >completly exiting the driver init code. > > Completely. > > >Signed-off-by: Ahmed S. Darwish <ahmed.darwish@...eo.com> > >--- > > drivers/net/can/usb/kvaser_usb.c | 12 ++++++++++-- > > 1 file changed, 10 insertions(+), 2 deletions(-) > > >diff --git a/drivers/net/can/usb/kvaser_usb.c b/drivers/net/can/usb/kvaser_usb.c > >index 640b0eb..068e76c 100644 > >--- a/drivers/net/can/usb/kvaser_usb.c > >+++ b/drivers/net/can/usb/kvaser_usb.c > [...] > >@@ -1632,7 +1632,15 @@ static int kvaser_usb_probe(struct usb_interface *intf, > > > > usb_set_intfdata(intf, dev); > > > >- err = kvaser_usb_get_software_info(dev); > >+ /* On some x86 laptops, plugging a Kvaser device again after > >+ * an unplug makes the firmware always ignore the very first > >+ * command. For such a case, provide some room for retries > >+ * instead of completly exiting the driver. > > Completely. > Thanks, both fixed in the next submission :-D Regards, Darwish -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists