netdev - Re: [PATCH 2/4] net: wan: add missing virt_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 28 Jan 2015 17:19:10 +0100
From:	Jan Kasprzak <kas@...muni.cz>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	netdev@...r.kernel.org, davem@...emloft.net,
	linux-arm-kernel@...ts.infradead.org,
	linux-pcmcia@...ts.infradead.org, jeffrey.t.kirsher@...el.com
Subject: Re: [PATCH 2/4] net: wan: add missing virt_to_bus dependencies

Arnd Bergmann wrote:
: The cosa driver is rather outdated and does not get built on most
: platforms because it requires the ISA_DMA_API symbol. However
: there are some ARM platforms that have ISA_DMA_API but no virt_to_bus,
: and they get this build error when enabling the ltpc driver.
: 
: drivers/net/wan/cosa.c: In function 'tx_interrupt':
: drivers/net/wan/cosa.c:1768:3: error: implicit declaration of function 'virt_to_bus'
:    unsigned long addr = virt_to_bus(cosa->txbuf);
:    ^
: 
: The same problem exists for the Hostess SV-11 and Sealevel Systems 4021
: drivers.

	Hello,

as for COSA, it is OK. Although I would like to know whether there still is
at least one COSA card in use somewhere :-)

Acked-By: Jan "Yenya" Kasprzak <kas@...muni.cz>

Thanks,

-Yenya

: 
: This adds another dependency in Kconfig to avoid that configuration.
: 
: Signed-off-by: Arnd Bergmann <arnd@...db.de>
: ---
:  drivers/net/wan/Kconfig | 6 +++---
:  1 file changed, 3 insertions(+), 3 deletions(-)
: 
: diff --git a/drivers/net/wan/Kconfig b/drivers/net/wan/Kconfig
: index 94e234975c61..a2fdd15f285a 100644
: --- a/drivers/net/wan/Kconfig
: +++ b/drivers/net/wan/Kconfig
: @@ -25,7 +25,7 @@ if WAN
:  # There is no way to detect a comtrol sv11 - force it modular for now.
:  config HOSTESS_SV11
:  	tristate "Comtrol Hostess SV-11 support"
: -	depends on ISA && m && ISA_DMA_API && INET && HDLC
: +	depends on ISA && m && ISA_DMA_API && INET && HDLC && VIRT_TO_BUS
:  	help
:  	  Driver for Comtrol Hostess SV-11 network card which
:  	  operates on low speed synchronous serial links at up to
: @@ -37,7 +37,7 @@ config HOSTESS_SV11
:  # The COSA/SRP driver has not been tested as non-modular yet.
:  config COSA
:  	tristate "COSA/SRP sync serial boards support"
: -	depends on ISA && m && ISA_DMA_API && HDLC
: +	depends on ISA && m && ISA_DMA_API && HDLC && VIRT_TO_BUS
:  	---help---
:  	  Driver for COSA and SRP synchronous serial boards.
:  
: @@ -87,7 +87,7 @@ config LANMEDIA
:  # There is no way to detect a Sealevel board. Force it modular
:  config SEALEVEL_4021
:  	tristate "Sealevel Systems 4021 support"
: -	depends on ISA && m && ISA_DMA_API && INET && HDLC
: +	depends on ISA && m && ISA_DMA_API && INET && HDLC && VIRT_TO_BUS
:  	help
:  	  This is a driver for the Sealevel Systems ACB 56 serial I/O adapter.
:  
: -- 
: 2.1.0.rc2

-- 
| Jan "Yenya" Kasprzak   <kas at {fi.muni.cz - work | yenya.net - private}> |
| New GPG 4096R/A45477D5 -- see http://www.fi.muni.cz/~kas/pgp-rollover.txt |
| http://www.fi.muni.cz/~kas/     Journal: http://www.fi.muni.cz/~kas/blog/ |
||| "New and improved" is only really improved if it also takes backwards |||
||| compatibility into account, rather than saying "now everybody must do |||
||| things the new and improved - and different - way"   --Linus Torvalds |||


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html