netdev - Re: [PATCH] ipv4: tcp: get rid of ugly unicast

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 01 Feb 2015 23:06:33 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] ipv4: tcp: get rid of ugly unicast_sock

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Thu, 29 Jan 2015 21:35:05 -0800

> From: Eric Dumazet <edumazet@...gle.com>
> 
> In commit be9f4a44e7d41 ("ipv4: tcp: remove per net tcp_sock")
> I tried to address contention on a socket lock, but the solution
> I chose was horrible :
> 
> commit 3a7c384ffd57e ("ipv4: tcp: unicast_sock should not land outside
> of TCP stack") addressed a selinux regression.
> 
> commit 0980e56e506b ("ipv4: tcp: set unicast_sock uc_ttl to -1")
> took care of another regression.
> 
> commit b5ec8eeac46 ("ipv4: fix ip_send_skb()") fixed another regression.
> 
> commit 811230cd85 ("tcp: ipv4: initialize unicast_sock sk_pacing_rate")
> was another shot in the dark.
> 
> Really, just use a proper socket per cpu, and remove the skb_orphan()
> call, to re-enable flow control.
> 
> This solves a serious problem with FQ packet scheduler when used in
> hostile environments, as we do not want to allocate a flow structure
> for every RST packet sent in response to a spoofed packet.
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Applied, thanks Eric.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html