lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 02 Feb 2015 16:42:56 -0800 From: "Nicholas A. Bellinger" <nab@...ux-iscsi.org> To: Al Viro <viro@...IV.linux.org.uk> Cc: David Miller <davem@...emloft.net>, netdev@...r.kernel.org, "Michael S. Tsirkin" <mst@...hat.com>, kvm@...r.kernel.org, target-devel <target-devel@...r.kernel.org> Subject: Re: [PATCH v2 18/18] vhost: vhost_scsi_handle_vq() should just use copy_from_user() Hi Al, On Mon, 2015-02-02 at 07:59 +0000, Al Viro wrote: > From: Al Viro <viro@...iv.linux.org.uk> > > it has just verified that it asks no more than the length of the > first segment of iovec. > > And with that the last user of stuff in lib/iovec.c is gone. > RIP. > > Cc: Michael S. Tsirkin <mst@...hat.com> > Cc: Nicholas A. Bellinger <nab@...ux-iscsi.org> > Cc: kvm@...r.kernel.org > Signed-off-by: Al Viro <viro@...iv.linux.org.uk> > --- > drivers/vhost/scsi.c | 2 +- > include/linux/uio.h | 2 -- > lib/Makefile | 2 +- > lib/iovec.c | 36 ------------------------------------ > 4 files changed, 2 insertions(+), 40 deletions(-) > delete mode 100644 lib/iovec.c > > diff --git a/drivers/vhost/scsi.c b/drivers/vhost/scsi.c > index d695b16..dc78d87 100644 > --- a/drivers/vhost/scsi.c > +++ b/drivers/vhost/scsi.c > @@ -1079,7 +1079,7 @@ vhost_scsi_handle_vq(struct vhost_scsi *vs, struct vhost_virtqueue *vq) > req_size, vq->iov[0].iov_len); > break; > } > - ret = memcpy_fromiovecend(req, &vq->iov[0], 0, req_size); > + ret = copy_from_user(req, vq->iov[0].iov_base, req_size); > if (unlikely(ret)) { > vq_err(vq, "Faulted on virtio_scsi_cmd_req\n"); > break; Is this in for-next yet..? If not, please push out ASAP so SFR can hit the conflict between target-pending/for-next as a heads up for Linus.. --nab -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists