netdev - Re: [PATCH] ath9k_htc: add adaptive usb flow control to repair soft lockup with monitor mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 03 Feb 2015 15:35:25 +0100
From:	Oleksij Rempel <linux@...pel-privat.de>
To:	Kalle Valo <kvalo@...eaurora.org>, yuweizheng@....com
CC:	linux-kernel@...r.kernel.org, ath9k-devel@...ts.ath9k.org,
	linux-wireless@...r.kernel.org, ath9k-devel@....qualcomm.com,
	netdev@...r.kernel.org, Yuwei Zheng <zhengyuwei@....cn>
Subject: Re: [PATCH] ath9k_htc: add adaptive usb flow control to repair soft
 lockup with monitor mode

It seems to work without noticeable regressions.

Am 03.02.2015 um 12:52 schrieb Kalle Valo:
> yuweizheng@....com writes:
> 
>> From: Yuwei Zheng <yuweizheng@....com>
>>
>> In the environment with heavy wifi traffic, set the ar9271 into monitor mode, will
>> trigger a deadloop panic.
>>  
>> The ath9k_hif_usb_rx_cb function excute on  the interrupt context, and ath9k_rx_tasklet excute
>> on the soft irq context. In other words, the ath9k_hif_usb_rx_cb have more chance to excute than
>> ath9k_rx_tasklet.  So in the worst condition,  the rx.rxbuf receive list is always full,
>> and the do {}while(true) loop will not be break. The kernel get a soft lockup panic. 
> 
> The word wrapping is still wrong, please limit the width to 72 chars or
> so. But no need to wrap log snippets, they can exceed the limit.
> 
>> Signed-off-by: Yuwei Zheng <zhengyuwei@....cn>
>> Signed-off-by: Yuwei Zheng <yuweizheng@....com>
> 
> Why two of these? Please use just one Signed-off-by line. Unless these
> are two different persons with the same name :)
> 


-- 
Regards,
Oleksij


Download attachment "signature.asc" of type "application/pgp-signature" (214 bytes)