netdev - Re: [net-next 03/16] ixgbe: cleanup sparse errors in new ixgbe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 05 Feb 2015 14:40:07 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	David.Laight@...LAB.COM
Cc:	jeffrey.t.kirsher@...el.com, donald.c.skidmore@...el.com,
	netdev@...r.kernel.org, nhorman@...hat.com, sassmann@...hat.com,
	jogreene@...hat.com
Subject: Re: [net-next 03/16] ixgbe: cleanup sparse errors in new
 ixgbe_x550.c file

From: David Laight <David.Laight@...LAB.COM>
Date: Thu, 5 Feb 2015 09:48:24 +0000

> From: Jeff Kirsher
>> This patch cleans up prototypes that should have been defined
>> as static.
>> 
>> Signed-off-by: Don Skidmore <donald.c.skidmore@...el.com>
>> Tested-by: Phil Schmitt <phillip.j.schmitt@...el.com>
>> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
>> ---
>>  drivers/net/ethernet/intel/ixgbe/ixgbe_type.h |  4 +-
>>  drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c | 65 ++++++++++++++-------------
>>  2 files changed, 37 insertions(+), 32 deletions(-)
>> 
>> diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_type.h
>> b/drivers/net/ethernet/intel/ixgbe/ixgbe_type.h
>> index d101b25..1f301ec 100644
>> --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_type.h
>> +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_type.h
>> @@ -2451,8 +2451,8 @@ struct ixgbe_hic_read_shadow_ram {
>> 
>>  struct ixgbe_hic_write_shadow_ram {
>>  	union ixgbe_hic_hdr2 hdr;
>> -	u32 address;
>> -	u16 length;
>> +	__be32 address;
>> +	__be16 length;
>>  	u16 pad2;
>>  	u16 data;
>>  	u16 pad3;
> 
> Not related to commit message

Agreed, fix this up.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html