netdev - Re: [PATCH net-next 1/3] net: Rename sock_recv_ts_and_drops() to sock_cmsg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 09 Feb 2015 18:55:35 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	eyal.birger@...il.com
Cc:	edumazet@...gle.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next 1/3] net: Rename sock_recv_ts_and_drops() to
 sock_cmsg_recv()

From: Eyal Birger <eyal.birger@...il.com>
Date: Mon,  9 Feb 2015 20:15:21 +0200

> -void __sock_recv_ts_and_drops(struct msghdr *msg, struct sock *sk,
> +void __sock_cmsg_recv(struct msghdr *msg, struct sock *sk,
>  			      struct sk_buff *skb);

If you change the column where the openning parenthesis of a function
declaration appears, you have to reindent the subsequent lines,
if any, so that the arguments still begin at the first column after
that openning parenthesis.

>  
> -static inline void sock_recv_ts_and_drops(struct msghdr *msg, struct sock *sk,
> +static inline void sock_cmsg_recv(struct msghdr *msg, struct sock *sk,
>  					  struct sk_buff *skb)

Likewise.

Please audit your entire patch series for this problem before resubmitting.

Also, this new feature is too late for this merge window, so there is
no rush for resubmitting this.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html