[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Wed, 18 Feb 2015 21:59:53 -0800
From: Guenter Roeck <linux@...ck-us.net>
To: Florian Fainelli <f.fainelli@...il.com>
Cc: netdev@...r.kernel.org, davem@...emloft.net,
vivien.didelot@...oirfairelinux.com,
jerome.oufella@...oirfairelinux.com, andrew@...n.ch,
cphealy@...il.com
Subject: Re: [PATCH RFC 2/2] net: dsa: bcm_sf2: implement HW bridging
operations
On Wed, Feb 18, 2015 at 06:48:19PM -0800, Florian Fainelli wrote:
> On 17/02/15 11:26, Florian Fainelli wrote:
> > Update the Broadcom Starfighter 2 switch driver to implement the
> > join/leave/stp_update callbacks required for basic hardware bridging
> > support.
> >
> > There is not much to be done at the driver level but translating the
> > STP state from Linux to their HW values.
> >
> > Joining a bridge means that the joining port and the other port members
> > need to be in the same VLAN membership as the CPU, while leaving the
> > bridge puts the port back into a separate VLAN membership with only the
> > CPU.
>
> I found a couple additional issues while testing:
>
> - manipulating UP/DOWN state of interfaces that are part of a bridge
> would not restore their bridge membership
>
> - removing an interface from a bridge and bringing it back up would
> leave it in blocked state
>
Is this a problem with your implementation for sf2 or a generic problem
with the first patch, such as some missing state transitions ?
For sf2, you might have to set the port state as well as the bridge
association in the port_setup function. That is of course just a
wild guess.
Thanks,
Guenter
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists