netdev - Re: [PATCH next v6 2/5] bonding: Implement port churn-machine (AD standard 43.4.17).

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 20 Feb 2015 17:33:45 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	maheshb@...gle.com
Cc:	j.vosburgh@...il.com, andy@...yhouse.net, vfalico@...il.com,
	nikolay@...hat.com, maze@...gle.com, netdev@...r.kernel.org,
	edumazet@...gle.com
Subject: Re: [PATCH next v6 2/5] bonding: Implement port churn-machine (AD
 standard 43.4.17).

From: Mahesh Bandewar <maheshb@...gle.com>
Date: Wed, 18 Feb 2015 22:50:19 -0800

> @@ -1131,6 +1137,44 @@ static void ad_rx_machine(struct lacpdu *lacpdu, struct port *port)
>  	}
>  }
>  
> +/* ad_churn_machine - handle port churn's state machine
> + * @port: the port we're looking at
> + *
> + */

Please don't invent new styles for the function comments, do it like it is
done in the rest of this file, for example, the very next funtion does:

>  /**
>   * ad_tx_machine - handle a port's tx state machine
>   * @port: the port we're looking at
> +	static const char *const churn_description[] =
> +		{ "monitoring",
> +		  "churned",
> +		  "none",
> +		  "unknown"
> +		};
> +	int max_size = sizeof(churn_description) / sizeof(churn_description[0]);

Please format this as:

> +	static const char *const churn_description[] = {
> +		"monitoring",
> +		"churned",
> +		"none",
> +		"unknown"
> +	};
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html