netdev - Re: [PATCH v2 net-next 2/2] multicast: Extend ip address command to enable multicast group join/leave on IP level.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 21 Feb 2015 19:04:21 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	challa@...ronetworks.com
Cc:	eric.dumazet@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH v2 net-next 2/2] multicast: Extend ip address command
 to enable multicast group join/leave on IP level.

From: Madhu Challa <challa@...ronetworks.com>
Date: Tue, 17 Feb 2015 17:19:06 -0800

>     Joining multicast group on ethernet level via "ip maddr" command would
>     not work if we have an Ethernet switch that does igmp snooping since
>     the switch would not replicate multicast packets on ports that did not
>     have IGMP reports for the multicast addresses.
> 
>     Linux vxlan interfaces created via "ip link add vxlan" have the group option
>     that enables then to do the required join.
> 
>     By extending ip address command with option "autojoin" we can get similar
>     functionality for openvswitch vxlan interfaces as well as other tunneling
>     mechanisms that need to receive multicast traffic. The kernel code is
>     structured similar to how the vxlan driver does a group join / leave.
> 
>     example:
>     ip address add 224.1.1.10/24 dev eth5 autojoin
>     ip address del 224.1.1.10/24 dev eth5
> 
>     v2 address review comments from Eric Dumazet.
> 
>     This patch applies on top of
>     [PATCH net-next] igmp: add __ip_mc_{join|leave}_group()
>     by Eric Dumazet. and
>     igmp v6: add __ipv6_sock_mc_join and __ipv6_sock_mc_drop
> 
>     remove the work queue and call the __ip_mc_{join|leave}_group
>     and the ipv6 variant __ipv6_sock_mc_{join|drop}
> 
>     Signed-off-by: Madhu Challa <challa@...ronetworks.com>

Please do not add this indentation to every line in your commit message.

Also, you should provide a "[PATCH net-next 0/2] xxx" posting that explains
at a high level what your patch series is doing, and why.

> +static int ip_mc_config(struct sock *sk, bool join, __be32 saddr, int ifindex)
> +{
> +	int ret;
> +	struct ip_mreqn mreq = {
> +		.imr_multiaddr.s_addr = saddr,
> +		.imr_ifindex = ifindex,
> +	};

Please order local variable declarations in "reverse christmas tree"
ordering, meaning longer lines before shorter ones.

> @@ -2740,6 +2740,8 @@ static const struct file_operations igmp_mcf_seq_fops = {
>  static int __net_init igmp_net_init(struct net *net)
>  {
>  	struct proc_dir_entry *pde;
> +	int err;
> +	struct socket *sock = NULL;
>  
>  	pde = proc_create("igmp", S_IRUGO, net->proc_net, &igmp_mc_seq_fops);
>  	if (!pde)

Likewise.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html