lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 01 Mar 2015 13:27:45 -0800 From: Eric Dumazet <eric.dumazet@...il.com> To: Tom Herbert <therbert@...gle.com> Cc: Florian Westphal <fw@...len.de>, David Miller <davem@...emloft.net>, Linux Netdev List <netdev@...r.kernel.org> Subject: Re: [PATCH net-next 3/6] flow_dissector: Add hash_extra field to flow_keys struct On Sun, 2015-03-01 at 09:55 -0800, Tom Herbert wrote: > Alternatively, I think we might be able to eliminate the use of > flow_keys and flow_dissect from the qdisc code altogether. It looks > like this is only being used to determine a hash over the addresses, > ports, and protocol so I am thinking that we can just call > skb_get_hash for that. Will try to post some patches soon. Note that SFQ only stored the keys in case of a potential rehash, and because skb->cb[] was available then. As the rehash implies to _not_ use skb_get_hash() it is simply better to recompute the flow key from packet, in the unlikely case we do have a rehash. Rehashing SFQ adds reorders, so people should think twice before using it. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists