netdev - Re: [net-next 09/18] i40e/i40evf: Add capability to gather VEB per TC stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 02 Mar 2015 17:34:12 -0800
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	David Miller <davem@...emloft.net>
Cc:	neerav.parikh@...el.com, netdev@...r.kernel.org,
	nhorman@...hat.com, sassmann@...hat.com, jogreene@...hat.com
Subject: Re: [net-next 09/18] i40e/i40evf: Add capability to gather VEB per
 TC stats

On Sat, 2015-02-28 at 23:30 -0500, David Miller wrote:
> From: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> Date: Sat, 28 Feb 2015 03:29:40 -0800
> 
> > From: Neerav Parikh <neerav.parikh@...el.com>
> > 
> > This patch adds capability to update per VEB per TC statistics and dump
> > it via debugfs. It also adds a structure to hold VEB per TC statistics.
> > The fields can be filled by reading the GLVEBTC_* counters.
> > 
> > Change-ID: I45cca003d8b12d96951a67f50d5dd7a789e09218
> > Signed-off-by: Neerav Parikh <neerav.parikh@...el.com>
> > Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> 
> For the umpteenth time, stop dumping statistics into debugfs.
> 
> Export them like any other statistic, via ethtool.
> 
> This applies to the existing debugfs you're building on top
> of in this change as well, I very much regret not catching
> that when it initially went in.
> 
> Please stop, in general, using debugfs as a dumping ground
> for thing you can't initially figure out how to export via
> normal standard interfaces.

Sorry that slipped by me as well, my fault for not catching it and
pushing back on the developer for putting this into ethtool stats.

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)