netdev - Re: [PATCH net-next v4 0/2] net: Introducing socket mark receive socket option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 02 Mar 2015 23:01:44 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	eyal.birger@...il.com
Cc:	fw@...len.de, willemb@...gle.com, edumazet@...gle.com,
	shmulik.ladkani@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v4 0/2] net: Introducing socket mark receive
 socket option

From: Eyal Birger <eyal.birger@...il.com>
Date: Tue, 3 Mar 2015 05:45:39 +0200

>>>> I'm not applying this series, it's use case is at best dubious to me and
>>>> there are security/protection concerns as well.
>>>
>>> I understand. Thanks.
>>>
>>> Would it be considered if access to the mark value was under CAP_NET_ADMIN
>>> similar to setting SO_MARK?
>>
>> I said there are two issues blocking it's inclusion, so dealing with only
>> one of those is insufficient, right?
> 
> Right. Thanks.
> 
> In that case I suggest reverting 744d5a3e9fe2690
> ("net: move skb->dropcount to skb->cb[]") as it has no justification without
> this feature and wastes 4 bytes of skb->cb[] space.

It may allow us to make other simplifications to sk_buff so I'm
keeping it in.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html