[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 2 Mar 2015 23:04:27 -0800
From: Marcel Holtmann <marcel@...tmann.org>
To: Joe Perches <joe@...ches.com>
Cc: netdev <netdev@...r.kernel.org>,
LKML <linux-kernel@...r.kernel.org>,
"Gustavo F. Padovan" <gustavo@...ovan.org>,
Johan Hedberg <johan.hedberg@...il.com>,
"David S. Miller" <davem@...emloft.net>,
linux-bluetooth@...r.kernel.org
Subject: Re: [PATCH net-next 10/14] bluetooth: Use eth_<foo>_addr instead of memset
Hi Joe,
> Use the built-in function instead of memset.
>
> Signed-off-by: Joe Perches <joe@...ches.com>
> ---
> net/bluetooth/bnep/netdev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/bluetooth/bnep/netdev.c b/net/bluetooth/bnep/netdev.c
> index 4b488ec..6ceb5d3 100644
> --- a/net/bluetooth/bnep/netdev.c
> +++ b/net/bluetooth/bnep/netdev.c
> @@ -218,7 +218,7 @@ static const struct net_device_ops bnep_netdev_ops = {
> void bnep_net_setup(struct net_device *dev)
> {
>
> - memset(dev->broadcast, 0xff, ETH_ALEN);
> + eth_broadcast_addr(dev->broadcast);
> dev->addr_len = ETH_ALEN;
Acked-by: Marcel Holtmann <marcel@...tmann.org>
Regards
Marcel
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists