netdev - Re: [PATCH net-next 06/14] xen: Use eth_<foo>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 3 Mar 2015 10:13:14 +0000
From:	Wei Liu <wei.liu2@...rix.com>
To:	Joe Perches <joe@...ches.com>
CC:	<netdev@...r.kernel.org>, Ian Campbell <ian.campbell@...rix.com>,
	Wei Liu <wei.liu2@...rix.com>,
	<xen-devel@...ts.xenproject.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next 06/14] xen: Use eth_<foo>_addr instead of memset

On Mon, Mar 02, 2015 at 07:54:51PM -0800, Joe Perches wrote:
> Use the built-in function instead of memset.
> 
> Signed-off-by: Joe Perches <joe@...ches.com>

Acked-by: Wei Liu <wei.liu2@...rix.com>

> ---
>  drivers/net/xen-netback/interface.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/xen-netback/interface.c b/drivers/net/xen-netback/interface.c
> index f38227a..4ae98e2 100644
> --- a/drivers/net/xen-netback/interface.c
> +++ b/drivers/net/xen-netback/interface.c
> @@ -438,7 +438,7 @@ struct xenvif *xenvif_alloc(struct device *parent, domid_t domid,
>  	 * stolen by an Ethernet bridge for STP purposes.
>  	 * (FE:FF:FF:FF:FF:FF)
>  	 */
> -	memset(dev->dev_addr, 0xFF, ETH_ALEN);
> +	eth_broadcast_addr(dev->dev_addr);
>  	dev->dev_addr[0] &= ~0x01;
>  
>  	netif_carrier_off(dev);
> -- 
> 2.1.2
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html