netdev - Re: [PATCH v4] bridge: fix bridge netlink RCU usage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 04 Mar 2015 00:20:44 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	johannes@...solutions.net
Cc:	netdev@...r.kernel.org, roopa@...ulusnetworks.com,
	stephen@...workplumber.org, johannes.berg@...el.com
Subject: Re: [PATCH v4] bridge: fix bridge netlink RCU usage

From: Johannes Berg <johannes@...solutions.net>
Date: Tue,  3 Mar 2015 16:02:16 +0100

> From: Johannes Berg <johannes.berg@...el.com>
> 
> When the STP timer fires, it can call br_ifinfo_notify(),
> which in turn ends up in the new br_get_link_af_size().
> This function is annotated to be using RTNL locking, which
> clearly isn't the case here, and thus lockdep warns:
> 
>   ===============================
>   [ INFO: suspicious RCU usage. ]
>   3.19.0+ #569 Not tainted
>   -------------------------------
>   net/bridge/br_private.h:204 suspicious rcu_dereference_protected() usage!
> 
> Fix this by doing RCU locking here.
> 
> Fixes: b7853d73e39b ("bridge: add vlan info to bridge setlink and dellink notification messages")
> Signed-off-by: Johannes Berg <johannes.berg@...el.com>

Applied to net-next, thanks Johannes.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html