netdev - Re: [PATCH net] tcp: align tcp_xmit_size_goal() on tcp_tso

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 5 Mar 2015 11:13:31 -0500
From:	Neal Cardwell <ncardwell@...gle.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	David Miller <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>,
	Yuchung Cheng <ycheng@...gle.com>
Subject: Re: [PATCH net] tcp: align tcp_xmit_size_goal() on tcp_tso_autosize()

On Thu, Mar 5, 2015 at 11:03 AM, Eric Dumazet <eric.dumazet@...il.com> wrote:
> From: Eric Dumazet <edumazet@...gle.com>
>
> With some mss values, it is possible tcp_xmit_size_goal() puts
> one segment more in TSO packet than tcp_tso_autosize().
>
> We send then one TSO packet followed by one single MSS.
>
> It is not a serious bug, but we can do slightly better, especially
> for drivers using netif_set_gso_max_size() to lower gso_max_size.
>
> Using same formula avoids these corner cases and makes
> tcp_xmit_size_goal() a bit faster.
>
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Fixes: 605ad7f184b6 ("tcp: refine TSO autosizing")

Acked-by: Neal Cardwell <ncardwell@...gle.com>

neal
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html