lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 08 Mar 2015 11:25:42 -0700 From: Jeff Kirsher <tarbal@...il.com> To: Stephen Hemminger <stephen@...workplumber.org>, David Miller <davem@...emloft.net> CC: netdev@...r.kernel.org Subject: Re: [PATCH net-next] vlan: allow changing VLAN id and protocol -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 On 03/08/2015 11:06 AM, Stephen Hemminger wrote: > > The VLAN netlink interface allows changing the ID and protocol of an existing > VLAN, but it was being ignored. Move the initialization of the proto and > id into the change function to fix that. > > Example of the problem: > # modprobe dummy > # ip li set dev dummy0 up > # ip li add link dummy0 name dummy0.10 type vlan id 100 > # ip li set dummy0.10 type vlan id 111 > # ip -d li show dev dummy0.10 > 19: dummy0.10@...my0: <BROADCAST,NOARP> mtu 1500 qdisc noop state DOWN mode DEFAULT > link/ether be:d3:7c:7f:86:18 brd ff:ff:ff:ff:ff:ff > vlan id 100 <REORDER_HDR> > ^^^ should be 111 > > Signed-off-by: Stephen Hemminger <stephen@...workplumber.org> Reviewed-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com> -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCgAGBQJU/JQlAAoJEOVv75VaS+3OnY8P/2JXfEavZqtBzK2wSRxaJ5o0 PU8FVutYDQ/DFFixEFtIaMY+nVpuViRXmUfowUEbXI5VOeoqwxhC5ek1V4c1TeAl 1gac0oY0ynqFHuAkj2MCkTR32IuOoLEjphekeYbJsLoMY4lF6iCXlQiJ+fboethk u10p10l4nE16gKCohLvrfW9TjXKF0SiRN70tqOWwwyrhL8YYL4ifE3AQbt3cStvw wzKrraMueodhtG1SJqVPnr2Iui7LN1hwQFH+J6V0RPYc6hqenQewgP+s4TaWd/a0 9iur1uJXnXvHGihh7HHIuF8ARQhSwlNRMXIq1T87F/qZIpHuUOouMDBZrrgSyBjJ QAM9gSL5Yd9HX91W1wxl00dvc00GdZFd+x9Zb7ROV42biiA1Yudua3TjzqEbwc61 JM5kR7GUiThqPcWmC+9YjYCbE1ciidepD3LxtjKBQdVIdDUiim0jLzUv1d45L3ne hsGuB6F64M0iTEHxM8c8NhwYiOpnl6lqaKAHAyGhBKLLlGkAyuktIr8+eXImxTz8 xu7q/DdX/z9/l8rNiqZmM9dI7cOrsW3BgvMi+/bpcbwe8vwIdir/GUpQ0duapG8z OiNt5Xqda18FsFUyLRe1iq1YbeRLpRt0c+guMMTqLaa1m4i2LwiEEnKF8Ofklk6q vA4U4evsyN4ROSUjJbAe =yuzw -----END PGP SIGNATURE----- -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists