lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 09 Mar 2015 09:47:04 -0400 From: Jamal Hadi Salim <jhs@...atatu.com> To: Scott Feldman <sfeldma@...il.com> CC: Netdev <netdev@...r.kernel.org>, "David S. Miller" <davem@...emloft.net>, Jiří Pírko <jiri@...nulli.us>, Roopa Prabhu <roopa@...ulusnetworks.com>, "alexander.h.duyck@...hat.com" <alexander.h.duyck@...hat.com> Subject: Re: [PATCH net-next v4 2/8] netdevice: add IPv4 fib add/del ops On 03/06/15 14:59, Scott Feldman wrote: > > I considered passing netlink flags in to driver, but the kernel logic > in fib_table_insert() already takes care of the checks required by the > flags, and from the driver's perspective, only three ops are needed: > add, del, and mod. And I've combined add and mod into the same op, > with the assumption the driver can know if an entry exists or not. > That assumption is not accurate. At least in some hardware i am working on right now a mod is cheaper than a create (and if i have to "know" wheter i should create or modify then i actually i have to query the hardware). cheers, jamal -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists