netdev - Re: [PATCH net-next] tipc: fix undefined __ipv6_sock_mc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 09 Mar 2015 22:37:28 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	ying.xue@...driver.com
Cc:	jon.maloy@...csson.com, Paul.Gortmaker@...driver.com,
	erik.hugne@...csson.com, fengguang.wu@...el.com,
	netdev@...r.kernel.org, tipc-discussion@...ts.sourceforge.net,
	kbuild-all@...org
Subject: Re: [PATCH net-next] tipc: fix undefined __ipv6_sock_mc_join
 compile error

From: Ying Xue <ying.xue@...driver.com>
Date: Tue, 10 Mar 2015 10:08:52 +0800

> When CONFIG_IPV6 option is disabled, below compile error appears while
> building TIPC module:
> 
> ERROR: "__ipv6_sock_mc_join" [net/tipc/tipc.ko] undefined!
> make[1]: *** [__modpost] Error 1
> make: *** [net/tipc/tipc.ko] Error 1
> 
> This is because we don't check whether or not the CONFIG_IPV6 is
> enabled when calling __ipv6_sock_mc_join().
> 
> Fixes: d0f91938bede ("tipc: add ip/udp media type")
> Reported-by: Wu Fengguang <fengguang.wu@...el.com>
> Cc: Kbuild test robot <kbuild-all@...org>
> Signed-off-by: Ying Xue <ying.xue@...driver.com>

Unfortunately, that's not sufficient.

You also need Kconfig guards to prevent building TIPC=y,
TIPC_MEDIA_UDP=y, and IPV6=m which will not work.

Look at other users of ipv6_*() interface, such as L2TP.
You need a dependency like (IPV6 || IPV6=n).
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html