netdev - Re: [PATCH net-next 1/8] net: Kill hold_net release

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 11 Mar 2015 12:36:48 -0500
From:	ebiederm@...ssion.com (Eric W. Biederman)
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	David Miller <davem@...emloft.net>, edumazet@...gle.com,
	netdev@...r.kernel.org, stephen@...workplumber.org,
	nicolas.dichtel@...nd.com, roopa@...ulusnetworks.com,
	hannes@...essinduktion.org, ddutt@...ulusnetworks.com,
	vipin@...ulusnetworks.com, shmulik.ladkani@...il.com,
	dsahern@...il.com, Julian Anastasov <ja@....bg>
Subject: Re: [PATCH net-next 1/8] net: Kill hold_net release_net

Eric Dumazet <eric.dumazet@...il.com> writes:

> On Wed, 2015-03-11 at 11:35 -0500, Eric W. Biederman wrote:
>
>> diff --git a/net/ipv4/inet_timewait_sock.c b/net/ipv4/inet_timewait_sock.c
>> index 6d592f8555fb..e0d5c8327159 100644
>> --- a/net/ipv4/inet_timewait_sock.c
>> +++ b/net/ipv4/inet_timewait_sock.c
>> @@ -98,7 +98,7 @@ void inet_twsk_free(struct inet_timewait_sock *tw)
>>  #ifdef SOCK_REFCNT_DEBUG
>>  	pr_debug("%s timewait_sock %p released\n", tw->tw_prot->name, tw);
>>  #endif
>> -	release_net(twsk_net(tw));
>> +	twsk_net(tw);
>>  	kmem_cache_free(tw->tw_prot->twsk_prot->twsk_slab, tw);
>>  	module_put(owner);
>>  }
>
>
> Not clear why you left this line ?

I goofed and then I overlooked the goof.

Eric

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html