netdev - Re: [PATCH RFC v2] ath10k: move code from parameter list into a function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 11 Mar 2015 20:22:41 +0100
From:	Johannes Berg <johannes@...solutions.net>
To:	Nicholas Mc Guire <der.herr@...r.at>
Cc:	Nicholas Mc Guire <hofrat@...dl.org>,
	Kalle Valo <kvalo@....qualcomm.com>, Valdis.Kletnieks@...edu,
	Bj??rn Mork <bjorn@...k.no>,
	Jeff Haran <Jeff.Haran@...rix.com>,
	Pat Erley <pat-lkml@...ey.org>, ath10k@...ts.infradead.org,
	linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH RFC v2] ath10k: move code from parameter list into a
 function

On Wed, 2015-03-11 at 20:15 +0100, Nicholas Mc Guire wrote:

> I'm not into this long enough to say what is better and if the consensus
> is that this patch is no more readable than the original code
> and no more maintainable either, then it is not worth the effort.

Personally, I like the change, it might even make that function more
reusable etc., and it gets rid of the ({ ... }) expression syntax which
I always find a bit odd :)

johannes

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html