netdev - RE: [PATCH] ixgbe: Remove NETIF_F_HW_VLAN_CTAG_FILTER from hw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 12 Mar 2015 06:00:50 +0000
From:	Hiroshi Shimamoto <h-shimamoto@...jp.nec.com>
To:	Alexander Duyck <alexander.h.duyck@...hat.com>,
	"e1000-devel@...ts.sourceforge.net" 
	<e1000-devel@...ts.sourceforge.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:	"jeffrey.t.kirsher@...el.com" <jeffrey.t.kirsher@...el.com>
Subject: RE: [PATCH] ixgbe: Remove NETIF_F_HW_VLAN_CTAG_FILTER from
 hw_features

> Subject: [PATCH] ixgbe: Remove NETIF_F_HW_VLAN_CTAG_FILTER from hw_features
> 
> This change makes it so that the HW_VLAN_STAG_FILTER bit is not falsely

s/STAG/CTAG/ right?

thanks,
Hiroshi

> advertised as being a feature that can be toggled on ixgbe parts.  The
> driver was setting the bit in features and letting it be inherited by
> hw_features, however the driver was actually ignoring the value of the bit
> and just assuming it was always set.  As a result VLAN filtering was always
> enabled which is a requirement for SR-IOV, VMDq, DCB, FCoE, and possibly
> other features within the adapters.
> 
> Signed-off-by: Alexander Duyck <alexander.h.duyck@...hat.com>
> ---
>  drivers/net/ethernet/intel/ixgbe/ixgbe_main.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
> index 21aea7e..08c27ed 100644
> --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
> +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
> @@ -8406,7 +8406,6 @@ skip_sriov:
>  			   NETIF_F_IPV6_CSUM |
>  			   NETIF_F_HW_VLAN_CTAG_TX |
>  			   NETIF_F_HW_VLAN_CTAG_RX |
> -			   NETIF_F_HW_VLAN_CTAG_FILTER |
>  			   NETIF_F_TSO |
>  			   NETIF_F_TSO6 |
>  			   NETIF_F_RXHASH |
> @@ -8428,6 +8427,7 @@ skip_sriov:
>  	}
> 
>  	netdev->hw_features |= NETIF_F_RXALL;
> +	netdev->features |= NETIF_F_HW_VLAN_CTAG_FILTER;
> 
>  	netdev->vlan_features |= NETIF_F_TSO;
>  	netdev->vlan_features |= NETIF_F_TSO6;