netdev - Re: [PATCH iproute2] tc class: Show class names from file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 15 Mar 2015 21:47:00 +0100
From:	Daniel Borkmann <daniel@...earbox.net>
To:	Vadim Kochan <vadim4j@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH iproute2] tc class: Show class names from file

Hi Vadim,

On 03/03/2015 05:41 PM, Vadim Kochan wrote:
> From: Vadim Kochan <vadim4j@...il.com>
>
> It is possible to use class names from file /etc/iproute2/cls_names
> which tc will use when showing class info:
>
>      # tc/tc -nm class show dev lo
> 	class htb 1:10 parent 1:1 leaf 10: prio 0 rate 5Mbit ceil 5Mbit burst 15Kb cburst 1600b
> 	class htb 1:1 root rate 6Mbit ceil 6Mbit burst 15Kb cburst 1599b
> 	class htb web#1:20 parent 1:1 leaf 20: prio 0 rate 3Mbit ceil 6Mbit burst 15Kb cburst 1599b
> 	class htb 1:2 root rate 6Mbit ceil 6Mbit burst 15Kb cburst 1599b
> 	class htb 1:30 parent 1:1 leaf 30: prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b
> 	class htb voip#1:40 parent 1:2 leaf 40: prio 0 rate 5Mbit ceil 5Mbit burst 15Kb cburst 1600b
> 	class htb 1:50 parent 1:2 leaf 50: prio 0 rate 3Mbit ceil 6Mbit burst 15Kb cburst 1599b
> 	class htb 1:60 parent 1:2 leaf 60: prio 0 rate 1Kbit ceil 6Mbit burst 15Kb cburst 1599b
>
> or to specify via file path:
>
>      # tc/tc -nm -cf /tmp/cls_names class show dev lo
>
> Class names file contains simple "maj:min  name" structure:
>
> 1:20    web
> 1:40    voip
>
> Signed-off-by: Vadim Kochan <vadim4j@...il.com>

in your patch, there are a couple of malloc() calls in your db
creation, that you should check if they actually fail, see i.e.
db_names_alloc(). Would be good if you could follow-up with a fix.

Thanks,
Daniel
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html