lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 15 Mar 2015 11:17:55 -0700 From: Scott Feldman <sfeldma@...il.com> To: Roopa Prabhu <roopa@...ulusnetworks.com> Cc: Jiří Pírko <jiri@...nulli.us>, "David S. Miller" <davem@...emloft.net>, Netdev <netdev@...r.kernel.org> Subject: Re: [PATCH net-next v2 1/3] switchdev: fix stp update API to work with layered netdevices On Thu, Mar 12, 2015 at 5:29 PM, <roopa@...ulusnetworks.com> wrote: > From: Roopa Prabhu <roopa@...ulusnetworks.com> > > make it same as the netdev_switch_port_bridge_setlink/dellink > api (ie traverse lowerdevs to get to the switch port). > > removes "WARN_ON(!ops->ndo_switch_parent_id_get)" because bridge ports > can be bonds and teams which might not implement this ndo. > > Signed-off-by: Roopa Prabhu <roopa@...ulusnetworks.com> NACK on this. This is a simpler implementation that doesn't touch team/bonding/vlan drivers and keeps traversal thru stacked devices in one place; see my other reply to 0/3 cover letter. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists