netdev - RE: [PATCH net-next 2/3] tipc: do not report -EHOSTUNREACH for failed local delivery

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 18 Mar 2015 15:28:05 +0000
From:	Jon Maloy <jon.maloy@...csson.com>
To:	Erik Hugne <erik.hugne@...csson.com>,
	Richard Alpe <richard.alpe@...csson.com>,
	"ying.xue@...driver.com" <ying.xue@...driver.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:	"tipc-discussion@...ts.sourceforge.net" 
	<tipc-discussion@...ts.sourceforge.net>
Subject: RE: [PATCH net-next 2/3] tipc: do not report -EHOSTUNREACH for
 failed local delivery



> -----Original Message-----
> From: Erik Hugne
> Sent: March-18-15 5:18 AM
> To: Richard Alpe; Jon Maloy; ying.xue@...driver.com;
> netdev@...r.kernel.org
> Cc: tipc-discussion@...ts.sourceforge.net; Erik Hugne
> Subject: [PATCH net-next 2/3] tipc: do not report -EHOSTUNREACH for failed
> local delivery
> 
> From: Erik Hugne <erik.hugne@...csson.com>
> 
> Since commit 1186adf7df04 ("tipc: simplify message forwarding and rejection
> in socket layer") -EHOSTUNREACH is propagated back to the sending process
> if we fail to deliver the message to another socket local to the node.
> This is wrong, host unreachable should only be reported when the
> destination port/name does not exist in the cluster, and that check is always
> done before sending the message. Also, this introduces inconsistent
> sendmsg() behavior for local/remote destinations. Errors occurring on the
> receiving side should not trickle up to the sender. If message delivery fails
> TIPC should either discard the packet or reject it back to the sender based on
> the destination droppable option.
> 
> Signed-off-by: Erik Hugne <erik.hugne@...csson.com>
Acked-by: Jon Maloy <jon.maloy@...csson.com>
> ---
>  net/tipc/link.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/net/tipc/link.c b/net/tipc/link.c index bc49120..8c98c4d 100644
> --- a/net/tipc/link.c
> +++ b/net/tipc/link.c
> @@ -845,8 +845,10 @@ int tipc_link_xmit(struct net *net, struct
> sk_buff_head *list, u32 dnode,
>  	if (link)
>  		return rc;
> 
> -	if (likely(in_own_node(net, dnode)))
> -		return tipc_sk_rcv(net, list);
> +	if (likely(in_own_node(net, dnode))) {
> +		tipc_sk_rcv(net, list);
> +		return 0;
> +	}
> 
>  	__skb_queue_purge(list);
>  	return rc;
> --
> 2.1.4

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html