netdev - Re: [PATCH 1/3] ipv4,ipv6: grab rtnl before locking the socket

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 18 Mar 2015 22:05:25 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	marcelo.leitner@...il.com
Cc:	netdev@...r.kernel.org, hannes@...essinduktion.org
Subject: Re: [PATCH 1/3] ipv4,ipv6: grab rtnl before locking the socket

From: Marcelo Ricardo Leitner <marcelo.leitner@...il.com>
Date: Wed, 18 Mar 2015 14:50:42 -0300

> There are some setsockopt operations in ipv4 and ipv6 that are grabbing
> rtnl after having grabbed the socket lock. Yet this makes it impossible
> to do operations that have to lock the socket when already within a rtnl
> protected scope, like ndo dev_open and dev_stop.
> 
> We normally take coarse grained locks first but setsockopt inverted that.
> 
> So this patch invert the lock logic for these operations and makes
> setsockopt grab rtnl if it will be needed prior to grabbing socket lock.
> 
> Signed-off-by: Marcelo Ricardo Leitner <marcelo.leitner@...il.com>
> Acked-by: Hannes Frederic Sowa <hannes@...essinduktion.org>

Applied to net-next.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html