lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 22 Mar 2015 13:06:30 +0000 From: Thomas Graf <tgraf@...g.ch> To: Herbert Xu <herbert@...dor.apana.org.au> Cc: "David S. Miller" <davem@...emloft.net>, Eric Dumazet <eric.dumazet@...il.com>, Patrick McHardy <kaber@...sh.net>, Josh Triplett <josh@...htriplett.org>, "Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>, netdev@...r.kernel.org Subject: Re: [v2 PATCH 7/10] rhashtable: Disable automatic shrinking On 03/22/15 at 12:17pm, Thomas Graf wrote: > On 03/22/15 at 07:04pm, Herbert Xu wrote: > > + struct bucket_table *new_tbl; > > + struct bucket_table *tbl; > > + int err; > > > > - ASSERT_RHT_MUTEX(ht); > > + if (size < ht->p.min_size) > > + size = ht->p.min_size; > > We should only shrink if size < old_tbl->size I found the check further down. Any particular reason why check after allocation and then free again? Why do you want to avoid the allocation inside the mutex? > > - new_tbl = bucket_table_alloc(ht, old_tbl->size / 2); > > + new_tbl = bucket_table_alloc(ht, size); > > if (new_tbl == NULL) > > return -ENOMEM; -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists