netdev - Re: [Patch net-next] net: clear skb->priority when forwarding to another netns

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 23 Mar 2015 16:43:53 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	xiyou.wangcong@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [Patch net-next] net: clear skb->priority when forwarding to
 another netns

From: Cong Wang <xiyou.wangcong@...il.com>
Date: Fri, 20 Mar 2015 14:29:09 -0700

> skb->priority can be set for two purposes:
> 
> 1) With respect to IP TOS field, which is computed by a mask.
> Ususally used for priority qdisc's (pfifo, prio etc.), on TX
> side (we only have ingress qdisc on RX side).
> 
> 2) Used as a classid or flowid, works in the same way with tc
> classid. What's more, this can even override the classid
> of tc filters.
> 
> For case 1), it has been respected within its netns, I don't
> see any point of keeping it for another netns, especially
> when packets will be forwarded to Rx path (no matter from TX
> path or RX path).
> 
> For case 2) we care, our applications run inside a netns,
> and we classify the packets by our own filters outside,
> If some application sets this priority, it could bypass
> our filters, therefore clear it when moving out of a netns,
> it makes no sense to bypass tc filters out of its netns.
> 
> Signed-off-by: Cong Wang <xiyou.wangcong@...il.com>

Applied, t hanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html