netdev - RE: [PATCH net-next v6 4/7] ixgbevf: Add a RETA query code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 23 Mar 2015 23:46:54 +0000
From:	"Tantilov, Emil S" <emil.s.tantilov@...el.com>
To:	Vlad Zolotarov <vladz@...udius-systems.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>,
	"avi@...udius-systems.com" <avi@...udius-systems.com>,
	"gleb@...udius-systems.com" <gleb@...udius-systems.com>
Subject: RE: [PATCH net-next v6 4/7] ixgbevf: Add a RETA query code

>-----Original Message-----
>From: netdev-owner@...r.kernel.org [mailto:netdev-owner@...r.kernel.org] On Behalf Of Vlad Zolotarov
>Sent: Sunday, March 22, 2015 12:01 PM
>
>Subject: [PATCH net-next v6 4/7] ixgbevf: Add a RETA query code
>
>   - Added a new API version support.
>   - Added the query implementation in the ixgbevf.
>
>Signed-off-by: Vlad Zolotarov <vladz@...udius-systems.com>
>---
>New in v6:
>   - Add a proper return code when an operation is blocked by PF.
>
>New in v3:
>   - Adjusted to the new interface IXGBE_VF_GET_RETA command.
>   - Added a proper support for x550 devices.
>
>New in v1 (compared to RFC):
>   - Use "if-else" statement instead of a "switch-case" for a single option case
>     (in ixgbevf_get_reta()).
>---
> drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c |  4 +-
> drivers/net/ethernet/intel/ixgbevf/mbx.h          |  8 ++
> drivers/net/ethernet/intel/ixgbevf/vf.c           | 92 +++++++++++++++++++++++
> drivers/net/ethernet/intel/ixgbevf/vf.h           |  1 +
> 4 files changed, 104 insertions(+), 1 deletion(-)
>
>diff --git a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
>index 4ee15ad..4787fcf 100644
>--- a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
>+++ b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
>@@ -2030,7 +2030,8 @@ static void ixgbevf_init_last_counter_stats(struct ixgbevf_adapter *adapter)
> static void ixgbevf_negotiate_api(struct ixgbevf_adapter *adapter)
> {
> 	struct ixgbe_hw *hw = &adapter->hw;
>-	int api[] = { ixgbe_mbox_api_11,
>+	int api[] = { ixgbe_mbox_api_12,
>+		      ixgbe_mbox_api_11,
> 		      ixgbe_mbox_api_10,
> 		      ixgbe_mbox_api_unknown };
> 	int err = 0, idx = 0;
>@@ -3712,6 +3713,7 @@ static int ixgbevf_change_mtu(struct net_device *netdev, int new_mtu)
> 
> 	switch (adapter->hw.api_version) {
> 	case ixgbe_mbox_api_11:
>+	case ixgbe_mbox_api_12:
> 		max_possible_frame = IXGBE_MAX_JUMBO_FRAME_SIZE;
> 		break;
> 	default:

You need another case for ixgbe_mbox_api_12 in ixgbevf_set_num_queues(), otherwise the driver will load with a single queue.

Thanks,
Emil

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html