netdev - Re: [PATCH net-next v6] switchdev: fix stp update API to work with layered netdevices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 23 Mar 2015 07:25:49 +0100
From:	Jiri Pirko <jiri@...nulli.us>
To:	roopa@...ulusnetworks.com
Cc:	davem@...emloft.net, sfeldma@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v6] switchdev: fix stp update API to work with
 layered netdevices

Sat, Mar 21, 2015 at 06:27:28PM CET, roopa@...ulusnetworks.com wrote:
>From: Roopa Prabhu <roopa@...ulusnetworks.com>
>
>make it same as the netdev_switch_port_bridge_setlink/dellink
>api (ie traverse lowerdevs to get to the switch port).
>
>removes "WARN_ON(!ops->ndo_switch_parent_id_get)" because
>direct bridge ports can be stacked netdevices (like bonds
>and team of switch ports) which may not implement this ndo.
>
>v2 to v3:
>	- remove changes to bond and team. Bring back the
>	transparently following lowerdevs like i initially
>	had for setlink/getlink
>	(http://www.spinics.net/lists/netdev/msg313436.html)
>	dave and scott feldman also seem to prefer it be that
>	way and move to non-transparent way of doing things
>	if we see a problem down the lane.
>
>v3 to v4:
>	- fix ret initialization
>
>v4 to v5:
>	- return err on first failure (scott feldman)
>
>v5 to v6:
>	- change variable name (err) and initialize to
>	-EOPNOTSUPP (scott feldman).
>
>Signed-off-by: Roopa Prabhu <roopa@...ulusnetworks.com>

Acked-by: Jiri Pirko <jiri@...nulli.us>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html