lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 23 Mar 2015 09:10:40 +0100 From: Richard Cochran <richardcochran@...il.com> To: Arnd Bergmann <arnd@...aro.org> Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org, Amir Vadai <amirv@...lanox.com>, Ariel Elior <ariel.elior@...gic.com>, Baolin Wang <baolin.wang@...aro.org>, Ben Hutchings <ben@...adent.org.uk>, Bruce Allan <bruce.w.allan@...el.com>, Carolyn Wyborny <carolyn.wyborny@...el.com>, Chris Metcalf <cmetcalf@...hip.com>, David Miller <davem@...emloft.net>, Frank Li <Frank.Li@...escale.com>, Giuseppe Cavallaro <peppe.cavallaro@...com>, Jeff Kirsher <jeffrey.t.kirsher@...el.com>, John Stultz <john.stultz@...aro.org>, Luwei Zhou <b45643@...escale.com>, Matthew Vick <matthew.vick@...el.com>, Michael Chan <mchan@...adcom.com>, Prashant Sreedharan <prashant@...adcom.com>, Shradha Shah <sshah@...arflare.com>, Solarflare linux maintainers <linux-net-drivers@...arflare.com>, Sonic Zhang <sonic.zhang@...log.com>, Stefan Sørensen <stefan.sorensen@...ctralink.com>, Thomas Gleixner <tglx@...utronix.de>, Tom Lendacky <thomas.lendacky@....com> Subject: Re: [PATCH net-next V2 20/23] ptp: dp83640: convert to the 64 bit get/set time methods. On Sun, Mar 22, 2015 at 06:48:02PM +0100, Arnd Bergmann wrote: > Ok, got it. The code looks correct then, though I'd like to see the use > of 'timespec' pushed out as far as possible. How about changing the > type for tdr_write() as well here? > > tdr_write() itself should be fine until 2106, as it writes an unsigned number, > but it's probably good to document that inside of that function. Arnd, thanks for the careful review. I will work out follow up patches for this driver and the i210 (igb) to address the remaining issues. For this series, lets leave tdr_write as is now, but I will surely take another look for the fix. Thanks, Richard -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists