netdev - Re: tcp_v4_err/request sock refcnt leak?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 23 Mar 2015 12:15:16 +0100
From:	Erik Hugne <erik.hugne@...csson.com>
To:	Fan Du <fengyuleidian0615@...il.com>
CC:	<netdev@...r.kernel.org>, Eric Dumazet <eric.dumazet@...il.com>
Subject: Re: tcp_v4_err/request sock refcnt leak?

On Mon, Mar 23, 2015 at 06:27:36PM +0800, Fan Du wrote:
> I'm not familiar with this part, IMHO, this might be a double call for reqsk_put?

Neither am i, but the below patch does not really make sense to me.

//E


> 
> 
> diff --git a/net/dccp/ipv4.c b/net/dccp/ipv4.c
> index 25a9615..fd805c0 100644
> --- a/net/dccp/ipv4.c
> +++ b/net/dccp/ipv4.c
> @@ -316,7 +316,6 @@ static void dccp_v4_err(struct sk_buff *skb, u32 info)
>  		 * errors returned from accept().
>  		 */
>  		inet_csk_reqsk_queue_drop(sk, req);
> -		reqsk_put(req);
>  		goto out;
> 
>  	case DCCP_REQUESTING:
> diff --git a/net/dccp/ipv6.c b/net/dccp/ipv6.c
> index 69d8f13..5137ab3 100644
> --- a/net/dccp/ipv6.c
> +++ b/net/dccp/ipv6.c
> @@ -174,7 +174,6 @@ static void dccp_v6_err(struct sk_buff *skb, struct inet6_skb_parm *opt,
>  		}
> 
>  		inet_csk_reqsk_queue_drop(sk, req);
> -		reqsk_put(req);
>  		goto out;
> 
>  	case DCCP_REQUESTING:
> diff --git a/net/ipv4/tcp_ipv4.c b/net/ipv4/tcp_ipv4.c
> index 5554b8f..b1eaf3d 100644
> --- a/net/ipv4/tcp_ipv4.c
> +++ b/net/ipv4/tcp_ipv4.c
> @@ -487,7 +487,6 @@ void tcp_v4_err(struct sk_buff *icmp_skb, u32 info)
>  		 */
>  		inet_csk_reqsk_queue_drop(sk, req);
>  		NET_INC_STATS_BH(sock_net(sk), LINUX_MIB_LISTENDROPS);
> -		reqsk_put(req);
>  		goto out;
> 
>  	case TCP_SYN_SENT:
> diff --git a/net/ipv6/tcp_ipv6.c b/net/ipv6/tcp_ipv6.c
> index 6e3f90d..1d551fa 100644
> --- a/net/ipv6/tcp_ipv6.c
> +++ b/net/ipv6/tcp_ipv6.c
> @@ -427,7 +427,6 @@ static void tcp_v6_err(struct sk_buff *skb, struct inet6_skb_parm *opt,
> 
>  		inet_csk_reqsk_queue_drop(sk, req);
>  		NET_INC_STATS_BH(sock_net(sk), LINUX_MIB_LISTENDROPS);
> -		reqsk_put(req);
>  		goto out;
> 
>  	case TCP_SYN_SENT:
> 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html