netdev - Re: [PATCH net-next] tcp: fix ipv4 mapped request socks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 25 Mar 2015 00:57:38 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next] tcp: fix ipv4 mapped request socks

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Tue, 24 Mar 2015 21:45:56 -0700

> From: Eric Dumazet <edumazet@...gle.com>
> 
> ss should display ipv4 mapped request sockets like this :
> 
> tcp    SYN-RECV   0      0  ::ffff:192.168.0.1:8080   ::ffff:192.0.2.1:35261 
> 
> and not like this :
> 
> tcp    SYN-RECV   0      0  192.168.0.1:8080   192.0.2.1:35261 
> 
> We should init ireq->ireq_family based on listener sk_family,
> not the actual protocol carried by SYN packet.
> 
> This means we can set ireq_family in inet_reqsk_alloc()
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Fixes: 3f66b083a5b7 ("inet: introduce ireq_family")

Applied, thanks Eric.

Please put the Fixes: tag before all the signoffs and acks
in the future, thanks in advance.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html