netdev - Re: [PATCH net-next] bonding: Remove hardcoded initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 30 Mar 2015 10:25:09 -0400
From:	Andy Gospodarek <gospo@...ulusnetworks.com>
To:	Mahesh Bandewar <maheshb@...gle.com>
Cc:	Jay Vosburgh <j.vosburgh@...il.com>,
	Andy Gospodarek <andy@...yhouse.net>,
	Veaceslav Falico <vfalico@...il.com>,
	Nikolay Aleksandrov <nikolay@...hat.com>,
	David Miller <davem@...emloft.net>,
	Maciej Zenczykowski <maze@...gle.com>,
	netdev <netdev@...r.kernel.org>,
	Eric Dumazet <edumazet@...gle.com>
Subject: Re: [PATCH net-next] bonding: Remove hardcoded initialization

On Fri, Mar 27, 2015 at 10:34:31PM -0700, Mahesh Bandewar wrote:
> Signed-off-by: Mahesh Bandewar <maheshb@...gle.com>

I realize that the changelog would be identical to the title, so
probably not critical here, but please add one whenever possible.

Signed-off-by: Andy Gospodarek <gospo@...ulusnetworks.com>

> ---
>  drivers/net/bonding/bond_3ad.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/bonding/bond_3ad.c b/drivers/net/bonding/bond_3ad.c
> index 3cce25818b57..48f3bd7e2350 100644
> --- a/drivers/net/bonding/bond_3ad.c
> +++ b/drivers/net/bonding/bond_3ad.c
> @@ -1776,7 +1776,7 @@ static void ad_initialize_port(struct port *port, int lacp_fast)
>  
>  		port->is_enabled = true;
>  		/* private parameters */
> -		port->sm_vars = 0x3;
> +		port->sm_vars = AD_PORT_BEGIN | AD_PORT_LACP_ENABLED;
>  		port->sm_rx_state = 0;
>  		port->sm_rx_timer_counter = 0;
>  		port->sm_periodic_state = 0;
> -- 
> 2.2.0.rc0.207.ga3a616c
> 
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html