lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 31 Mar 2015 19:34:57 -0700 From: Petri Gynther <pgynther@...gle.com> To: David Miller <davem@...emloft.net> Cc: netdev <netdev@...r.kernel.org>, Florian Fainelli <f.fainelli@...il.com>, Jaedon Shin <jaedon.shin@...il.com> Subject: Re: [PATCH net-next] net: bcmgenet: enable MoCA link state change detection On Tue, Mar 31, 2015 at 6:00 PM, David Miller <davem@...emloft.net> wrote: > From: Petri Gynther <pgynther@...gle.com> > Date: Tue, 31 Mar 2015 15:00:08 -0700 (PDT) > >> @@ -513,6 +522,13 @@ static int bcmgenet_mii_pd_init(struct bcmgenet_priv *priv) >> dev_err(kdev, "failed to register fixed PHY device\n"); >> return -ENODEV; >> } >> + >> + if (priv->hw_params->flags & GENET_HAS_MOCA_LINK_DET) { >> + ret = fixed_phy_set_link_update(phydev, >> + bcmgenet_fixed_phy_link_update); > > This is not indented correctly. > > When a function call or declaration or definition spans multiple lines, > arguments on the second and subsequent lines must be indented exactly > to the first column after the openning parenthesis on the first line. > > If you are strictly using TAB characters, it is exceedingly likely > that you are indenting these lines incorrectly. You must use the > appropriate number of TAB, then SPACE characters necessary to reach > the correct column. I'm aware of the Linux indentation rules. However, if I do that in this case, the second line becomes longer than 80 chars. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists